chore(lib/vm): update corosensei to 0.3.0 to support AddressSanitizer#5763
Merged
syrusakbary merged 1 commit intowasmerio:mainfrom Sep 29, 2025
StackOverflowExcept1on:update-corosensei
Merged
chore(lib/vm): update corosensei to 0.3.0 to support AddressSanitizer#5763syrusakbary merged 1 commit intowasmerio:mainfrom StackOverflowExcept1on:update-corosensei
corosensei to 0.3.0 to support AddressSanitizer#5763syrusakbary merged 1 commit intowasmerio:mainfrom
StackOverflowExcept1on:update-corosensei
Conversation
Member
|
Thanks for the PR. |
Contributor
Author
|
@syrusakbary thx for quick reply! looks like we also need to fix stack caching somehow |
Contributor
Author
|
@syrusakbary done! I checked API changes in benchmarks here: Amanieu/corosensei#58, Amanieu/corosensei#60. |
Member
|
In general it looks good to me (I wonder if it might be better to do Note: the tests failing have nothing to do with the code changes from this PR |
Contributor
|
It makes no difference, the scope is just there to ensure the coroutine is properly dropped at the end of the scope. This code is fine as it is. |
syrusakbary
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #5721
See #5746